Multichain layout prod #1808
Merged
Multichain layout prod #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… first deposit flag
…r in GmxAccountModal
… settlement and multichain claims, including nonce management and transaction signing enhancements.
…in useMultichainEvents and integrate it into useMultichainFundingToast for toast closure handling.
…simplifying state dependencies for button text logic.
…csEventsProvider, adding support for multichain actions and refining local action updates based on transaction parameters.
…al, refactoring to separate handling for settlement and multichain claims, enhancing transaction signing and nonce management.
…mproved error handling and user feedback for claiming fees, including toast notifications for success and failure states.
…rySection to display formatted date with comma
…veDateWithComma for improved user experience, updating display logic for sent timestamps.
… functionality for error toast notifications when minimum balance warnings are triggered.
…izing imports for improved code clarity and performance.
…o multichain-layout-prod
…ace into multichain-layout-prod
…o multichain-layout-prod
midas-myth
commented
Sep 2, 2025
vite.config.ts
Outdated
| @@ -50,7 +50,7 @@ export default defineConfig(({ mode }) => { | |||
| build: { | |||
| assetsInlineLimit: 0, | |||
| outDir: "build", | |||
| sourcemap: true, | |||
| sourcemap: false, | |||
There was a problem hiding this comment.
will remove to true
midas-myth
commented
Sep 2, 2025
tsconfig.json
Outdated
| @@ -27,5 +27,5 @@ | |||
| } | |||
| }, | |||
| "references": [{ "path": "./sdk" }], | |||
| "include": ["src", "scripts", "sdk/src/utils/twap/twap"] | |||
| "include": ["src", "scripts", "sdk/src/utils/trade/decrease.ts"] | |||
There was a problem hiding this comment.
deleted and left only two first
…ace into multichain-layout-prod
midas-myth
commented
Sep 2, 2025
package.json
Outdated
| "typescript": "5.4.2", | ||
| "use-context-selector": "1.4.1", | ||
| "viem": "2.7.20", | ||
| "viem": "2.26.2", |
There was a problem hiding this comment.
will update to 2.7.20
There was a problem hiding this comment.
updated to 2.37.1
…ace into multichain-layout-prod
midas-myth
commented
Sep 2, 2025
There was a problem hiding this comment.
Not used. will delete
divhead
approved these changes
Sep 2, 2025
gmxer
reviewed
Sep 3, 2025
| // isTaken: !isAddressZero(ownerOnOtherNetwork), | ||
| // isTakenByCurrentUser: | ||
| // !isAddressZero(ownerOnOtherNetwork) && ownerOnOtherNetwork.toLowerCase() === account.toLowerCase(), | ||
| // }, |
There was a problem hiding this comment.
no, deleted code comments
| }; | ||
| }; | ||
|
|
||
| export function getUSDValue(value, decimals = 2) { |
There was a problem hiding this comment.
getUSDValue -> getUsdValue
isn't it redundant function?
There was a problem hiding this comment.
renamed but the amount of usages justifies wrapping imo
| <br /> | ||
| <br /> | ||
| You sign each transaction on-chain using your own RPC, typically provided by your wallet. Gas | ||
| payments in ETH. |
There was a problem hiding this comment.
indeed, will fix here and below
| // onSelectToken(filteredTokens[0]); | ||
| // } | ||
| // } | ||
| // }; |
| // resetSubaccountApproval(); | ||
| // } else { | ||
| // refreshSubaccountData(); | ||
| // } |
|
|
||
| export function isStepGreaterOrEqual( | ||
| step: MultichainFundingHistoryItem["step"], | ||
| than: MultichainFundingHistoryItem["step"] |
There was a problem hiding this comment.
why next?
its not then its than
| const amountReceivedLD = quoteOft?.receipt.amountReceivedLD as bigint; | ||
|
|
||
| // ETH is the same as the source chain | ||
| // TODO: check if this is correct |
|
|
||
| // factorByTime > factorByAccount |
| @@ -28,7 +28,7 @@ export async function getGasLimit( | |||
| } | |||
|
|
|||
| if (gasLimit < 22000) { | |||
| gasLimit = 22000n; | |||
| gasLimit = 220000n; | |||
| [ARBITRUM]: "arbitrum", | ||
| [AVALANCHE]: "avalanche", | ||
| [AVALANCHE_FUJI]: "fuji", | ||
| // [BASE_MAINNET]: "base", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.